Initialize data store and routing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add redux.
This uses react-router-dom to introduce three main paths: - /, the default landing page - /auth, the interim authentication page - /schedules, /schedules/:id, the schedule list page and schedule planning page. TODO: Display list of schedules and handle sign-in.
This is temporary and will eventually be integrated as a dialog in the SchedulePlanner component.
Instead of keeping track of which students own which schedules through an owners array for each student, each schedule keeps track of its own owner.
aidigii
previously approved these changes
May 22, 2020
This was referenced Mar 23, 2023
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
akevinge
pushed a commit
that referenced
this pull request
Apr 7, 2023
This was referenced Jul 29, 2023
Closed
Merged
Closed
Merged
This was referenced Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1, resolves #2
Description of Changes
All the data types for Comet Planning have been defined in
src/lib/types.js. If you're using a code editor with IntelliSense like VSCode, these should help code autocomplete.Redux data store
This PR creates a Redux data store to hold reducers that manage app state. Each reducer corresponds to a different feature/data collection of the app such as
plannerfor schedules andcoursesfor courses.Router
This PR uses the React Router library to set up the routes described in #2.
Other Notes
Although this PR sets up the places to write code for rendered UI, it doesn't actually create pages. These should be created in laster PRs.