Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version check support for downloaded datasets #97

Open
HowcanoeWang opened this issue Apr 9, 2023 · 0 comments
Open

version check support for downloaded datasets #97

HowcanoeWang opened this issue Apr 9, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@HowcanoeWang
Copy link
Member

HowcanoeWang commented Apr 9, 2023

Thanks a lot for making this contribution, I will leave this PR for further discussion.

Before commiting, I run the pytest on my local machine every time. This non-reproducible problem is only caused by not updating the latest dataset in Google drive (and also the local Numpy versions).

To my understanding, the Action creates a new virtual envirnment each time to run the test code. But if is on a brand new environment, the pytest can not download the missing dataset automatically and raises FileNotFoundError in this case.

So this online test workflow may not be suitable for the cache rule. It requires the dataset initialize step for everytime in the Action virtual machine, and needs downloads such data again and again.

Personally prefer contributor running the pytest on their local enviroment, just like what scikit-learn and numpy require for pull request.

Then I need to figure out the following items:

  1. A solution to check the local dataset versions and support auto-update if it is out-of-date.
  2. Edit the 5 tests depend on the 3.3GB Lotus() dataset, using the 300MB TestData() only to decrease the required dataset size for testing

Originally posted by @HowcanoeWang in #87 (comment)

@HowcanoeWang HowcanoeWang self-assigned this Apr 9, 2023
@HowcanoeWang HowcanoeWang added the enhancement New feature or request label Apr 9, 2023
@HowcanoeWang HowcanoeWang added this to the 2.0.1 milestone Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant