Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Highlight Behavior #1538

Open
Meesch opened this issue Apr 11, 2024 · 3 comments
Open

Default Highlight Behavior #1538

Meesch opened this issue Apr 11, 2024 · 3 comments
Assignees
Labels
frontend changes to the angular frontend needs-mockup this suggestion could use a picture before it is implemented

Comments

@Meesch
Copy link
Contributor

Meesch commented Apr 11, 2024

We have heard from users in the IOS workshop that they expect the highlighter to be turned on by default when they make a query. Moreover, Berit has suggested that a 'toggle' button would be more clear than the current button.

@Meesch Meesch added the frontend changes to the angular frontend label Apr 11, 2024
@Meesch Meesch self-assigned this Apr 11, 2024
@Meesch Meesch changed the title Default Highlight Default Highlight Behavior Apr 11, 2024
@lukavdplas
Copy link
Contributor

Highighting was disabled by default for performance reasons, but I agree that makes more sense to enable it by default.

Re. user controls: the controls already include a toggle button, so what is meant by this? Removing the size controls? Changing the button text?

@lukavdplas lukavdplas added the needs-mockup this suggestion could use a picture before it is implemented label May 20, 2024
@Meesch
Copy link
Contributor Author

Meesch commented Jun 11, 2024

I think Berit meant that it should include a clear on/off switch, like so:
Screenshot 2024-06-11 at 11 50 01

@lukavdplas
Copy link
Contributor

So replace the toggle button with a switch? With or without the size controls?

My own suggestion would be to remove all highlight controls and just always turn on highlighting. The gains for users are negligible in my opinion, while the control adds complexity to the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend changes to the angular frontend needs-mockup this suggestion could use a picture before it is implemented
Projects
None yet
Development

No branches or pull requests

2 participants