Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty query not shown in compare query #1561

Open
lukavdplas opened this issue May 6, 2024 · 0 comments
Open

Empty query not shown in compare query #1561

lukavdplas opened this issue May 6, 2024 · 0 comments
Labels
bug something isn't working right frontend changes to the angular frontend visualisation changes to visualisation features

Comments

@lukavdplas
Copy link
Contributor

lukavdplas commented May 6, 2024

What went wrong?

The "compare query" option for the "number of results" visualisation should allow users to compare different search terms, but it does not allow you to include an empty query in the comparison, even though that is a valid input to the visualisation.

  1. If you searched without query text, select "compare with another query..." and add a search term, e.g. "test", the visualisation will only show results for "test", instead of adding those results as a second series.
  2. If you searched with query text, the UI doesn't offer any way to add an empty query to the comparison.

1 is a clear bug, 2 is a design flaw (and less urgent).

What did you expect to happen?

If you searched without query text, the "compare query" input should start with an "empty query" item. Like normal, the user can add more queries.

Re. the second issue: normally you would type in a search term and then hit comma/enter to "finish" it and add it in the query list. Perhaps you should be able to hit comma/enter immediately: if you have not typed in anything, the empty query will be added to the list. This is a bit arcane, though.

Screenshot

Screenshot of issue 1: I searched without search text and added "test" for comparison, so the plot should show a comparison between two sets of results.

screenshot of i-analyzer

Where did you find the bug?

Version

5.6.1

Steps to reproduce

Issue 1:

Issue 2:

@lukavdplas lukavdplas added bug something isn't working right frontend changes to the angular frontend visualisation changes to visualisation features labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working right frontend changes to the angular frontend visualisation changes to visualisation features
Projects
None yet
Development

No branches or pull requests

1 participant