Error when clearing query comparison

[lukavdplas]

What went wrong?

In the "number of results" visualisation, if you searched without a search term, use the "compare with another query" option to add additional queries, and then clear them, the visualisation displays an error message.

There are some additional problems with this error message:

• The error message is "[object Object]"
• If you enter a search term in the top bar, the visualisation will work properly again and load the new results, so the message should dissapear, but it does not.

Alternatively, you could try clearing the additional queries by using the "reset" button. This one does not show an error, but it also doesn't reset the visualisation: you'll still see the old data.

What did you expect to happen?

Obviously you should be able to mess around in the menu without encountering error messages. If they do occur, error messages should show a clear message, etc.

In the UI, it should be possible to clear / reset the query comparison menu if you searched without a query.

Solution 1:

• As also suggested in Empty query not shown in compare query #1561 : the empty query should be shown in the queries input.
• To prevent user error, the original query should be "locked", in that it can't be removed or changed.

Solution 2:

• The "compare queries" input should not show the original query at all, and only show additional queries
• This way, removing all comparison queries is always valid.

Solution 3:

• The empty query should be shown in the queries input.
• In this scenario, the reset button should restore the input to only contain the empty query again.
• If the user clears the query comparison input and clicks "confirm", the input value [] should be corrected to [""] (i.e. one item with the empty query) .

Screenshot

Where did you find the bug?

• https://ianalyzer.hum.uu.nl

Version

5.6.1

Steps to reproduce

• Go to https://ianalyzer.hum.uu.nl/search/dbnl?visualize=resultscount&visualizedField=periodical
• Select "compare with another query...", add a search term, click "confirm"
• Remove the search term and click confirm again

This will display an error message.

Also problematic:

• Go to https://ianalyzer.hum.uu.nl/search/dbnl?visualize=resultscount&visualizedField=periodical
• Select "compare with another query...", add a search term, click "confirm"
• Click "reset"

No error message, but the visualisation data isn't updated.