Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace prints with (debug) logger #12

Open
bbonf opened this issue May 21, 2024 · 0 comments · May be fixed by #13
Open

Replace prints with (debug) logger #12

bbonf opened this issue May 21, 2024 · 0 comments · May be fixed by #13
Labels
enhancement New feature or request

Comments

@bbonf
Copy link
Contributor

bbonf commented May 21, 2024

There are several places in the library where print() is used for warnings, errors or debug messages. That's convenient for local development but not when deployed on a server as part of GrETEL.

Specifically https://github.com/UUDigitalHumanitieslab/mwe-query/blob/develop/mwe_query/lcat.py#L189 seems to be happening often and overflowing logs that no one reads.
@bbonf bbonf added the enhancement New feature or request label May 21, 2024
@bbonf bbonf linked a pull request May 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace print statements with logging UUDigitalHumanitieslab/mwe-query
1 participant
@bbonf