-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/run in docker #17
Conversation
backend/parseport/settings.py
Outdated
'http://localhost:4200' | ||
] | ||
|
||
DEBUG = os.getenv('DJANGO_DEBUG', True) == 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite confusing and I also think it's not doing what you intended it to do:
- I think it's generally safer to have DEBUG off by default
- If I set FOO=1 then
os.getenv('FOO')
returns the string"1"
and not 1 True == 1
but"1" != 1
and on prod it's actually behaving ok because"0" != 1
My suggestion:
DEBUG = int(os.getenv('DJANGO_DEBUG', 0)) == 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, my bad! Good spot.
backend/parseport/settings.py
Outdated
"django.contrib.staticfiles", | ||
"rest_framework", | ||
"revproxy", | ||
"example", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove example
?
No description provided.