Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change detection of ETA in read_nm_tables index_table function to rem… #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MikeKSmith
Copy link

…ove digits and search from start of column name. Allows detection of variables like ETA_CL and ETA_V as type "eta". Closes #112

Question: Is it OK to assume that the "ETA" or "ET" comes at the start of the variable name?

…ove digits and search from start of column name. Allows detection of variables like ETA_CL and ETA_V as type "eta". Closes #112
@codecov
Copy link

codecov bot commented Sep 4, 2018

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          40       40           
  Lines        3057     3057           
=======================================
  Hits         2884     2884           
  Misses        173      173
Impacted Files Coverage Δ
R/read_nm_tables.R 92.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228b858...d3e77e6. Read the comment docs.

@billdenney
Copy link
Contributor

After applying this, my eta_distrib() fails when my ETAs are named "ETA(CL)" and similar:

eta_distrib(xpdb=xpdb)
Error in ETA(CL) : could not find function "ETA"

In my NONMEM model, I'm using:

$ABBR REPLACE ETA(CL)=ETA(2)

This is probably the same issue as #116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants