Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve precision of documentation of ... for xpose_data #98

Closed
wants to merge 2 commits into from

Conversation

billdenney
Copy link
Contributor

@billdenney billdenney commented May 18, 2018

Fixes #97

@codecov
Copy link

codecov bot commented May 18, 2018

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          40       40           
  Lines        3327     3327           
=======================================
  Hits         3191     3191           
  Misses        136      136
Impacted Files Coverage Δ
R/xpose_data.R 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4fd6a...a233b13. Read the comment docs.

@billdenney
Copy link
Contributor Author

As I've tried to work with this patch, there are a lot of places within xpose that expect the ID column to be named "ID". This patch breaks too many other things to be useful right now. I'm going to propose another patch that works the opposite direction (assigning the mapped name to the expected name).

@billdenney billdenney closed this May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant