Issue1263 durack1 Fix Travis OS X pyexpat build error #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aashish24 @doutriaux1 this is looking good, the |
This was referenced Nov 12, 2015
|
@aashish24 @jbeezley this is the PR that @doutriaux1 wanted you folks to take a look at.. |
| @@ -10,8 +10,6 @@ before_install: | |||
| - if [ "$TRAVIS_OS_NAME" = "osx" ]; then brew update ; brew outdated cmake || brew upgrade cmake ; fi | |||
| - cmake --version | |||
|
|
|||
| before_script: travis_wait | |||
There was a problem hiding this comment.
@jbeezley did you add this line?
There was a problem hiding this comment.
@aashish24 nope that was me - and it's redundant and did nothing.. For it to work to extend timeouts it needs to precede the command line arguments
|
@aashish24 any luck with reviewing this/figuring out what was/is happening? We're waiting on the PR to be merged so we can fix the downstream issue at PCMDI/pcmdi_metrics#279 along with some other fixes in the queue.. |
doutriaux1
added a commit
that referenced
this pull request
Nov 12, 2015
…yexpatBuildError Issue1263 durack1 Fix Travis OS X pyexpat build error
doutriaux1
deleted the
issue1263_durack1_FixTravisOSXPyexpatBuildError
branch
|
thanks @durack1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1263 - Travis OS X pyexpat build error - build against system expat
@aashish24 @doutriaux1 please review and merge - this will fix the
travisOS Xbuild errors, but it's a kludge as theexpatbuild errors are likely an artifact of problems with thebuildenvironment not being set up correctly - when running aPython 2.7.10build (which includesexpatandpyexpat) this completes successfully with no warnings outside of thecmakebuild command - take a peek at PCMDI/pcmdi_metrics#285 for more info.. PCMDI/pcmdi_metrics#279 was the issue that triggered this PR