fixed issue where old scr colormap file would not load opacity #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ def process_src(nm, code): | |||
| for i in range(255): | |||
| val = numbers[i * 3:i * 3 + 3] | |||
| if val != (): | |||
| d[i] = list(val) | |||
| d[i] = list(val)+[100] | |||
There was a problem hiding this comment.
@doutriaux1 can you exaplain bit more what this code is doing?
There was a problem hiding this comment.
old colormaps only had r,g,b values so when loading back in it only stores 3 values, then later on when using getcolor we unpack it into r,g,b,a causing a failure. Voila.
There was a problem hiding this comment.
Not Flake8 compliant.
Need spaces around binary operator "+".
There was a problem hiding this comment.
yet flake8 passes, bwwwaaaaaa I beat flake8!!!!!
fixes bug where flake8 does not see that the syntax was wrong and make @aashish24 and @sankhesh happy.
|
LGTM 👍 |
aashish24
added a commit
that referenced
this pull request
Nov 23, 2015
…rency_issue fixed issue where old scr colormap file would not load opacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aashish24 @sankhesh @chaosphere2112 just found a tiny bug. Please merge.