Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "limited view" permission #397

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented Oct 2, 2023

Add a new "limited view" permission. This permission is not used by the app yet, but the app may be expanded in the future to show a subset of information (e.g. list views, limited detail views) to users with this permission.

Eventually this permission will be used to allow non-CC users to
view some parts of the site, without the full set of information.
Add tests for users with the limited_view permission. Right now,
all the tests check that the views raise 403 forbidden errors, since
the app is not updated to use these views. In the future the tests
can be changed to expect new behavior, when the app is expanded to
allow these users to see a subset of information.
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #397 (15512e1) into main (3525ba6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   99.42%   99.44%   +0.01%     
==========================================
  Files         118      119       +1     
  Lines       21910    22377     +467     
==========================================
+ Hits        21785    22252     +467     
  Misses        125      125              
Files Coverage Δ
anvil_consortium_manager/__init__.py 100.00% <100.00%> (ø)
...ns/0013_alter_anvilprojectmanageraccess_options.py 100.00% <100.00%> (ø)
anvil_consortium_manager/models.py 100.00% <100.00%> (ø)
anvil_consortium_manager/tests/test_views.py 99.92% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amstilp amstilp merged commit 2b66c1f into main Oct 2, 2023
16 checks passed
@amstilp amstilp deleted the feature/limited-view-permission branch October 25, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant