Fix CI #401
Merged
Fix CI #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of mysqlclient requires pkg-config or that you set environemnt variables, which breaks soem CI. For now, downgrade the pkg-config requirements so that we can then fix them later. Note that CI is also breaking for other unknown reasons in a different branch, so we can see if it breaks here too... requires you
For some reason, it looks like Django v4.2 is being installed for the django41 env even though we are requesting 4.1.*. Try specifying the dependency differently. though we are requesting
This also requires setting the min tox version to 4.4.0.
Codecov Report
@@ Coverage Diff @@
## main #401 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 119 119
Lines 22335 22335
=======================================
Hits 22295 22295
Misses 40 40 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This should make the CI fail with mysqlclient>=2.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is breaking for a couple of possible reasons:
This PR hopefully fixes the issue with an incorrect version of Django being installed by adding a tox setting (constrain_package_deps). It appears that pkg-config may already be installed in the Docker image we're using, so the second is ok? Unclear if it fixes the third.