Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to unlink users from an Account #484

Merged
merged 12 commits into from
May 31, 2024

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented May 30, 2024

  • Add migration to store information about archived/unlinked users
  • Add view to unlink users
  • Show unlink button on AccountDetail page only if account has a linked user
  • Add information about previously linked users to account detail page
  • Confirm no migrations left
  • Redo/squash migrations before merge

Closes #482

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (511a782) to head (49ad21c).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #484    +/-   ##
========================================
  Coverage   99.75%   99.76%            
========================================
  Files         125      127     +2     
  Lines       23316    23722   +406     
========================================
+ Hits        23260    23666   +406     
  Misses         56       56            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amstilp added 11 commits May 31, 2024 09:52
For Accounts that have a linked user, show an "Unlink user" button
on the account detail page.
In addition to storing the unlinked user in the archive, also store
a link to the verified email entry, if it exists.
Add a method to the Account model that unlinks the user from an
instance of the model. Call that method in the view, instead of
encoding the logic in the view. Add tests for the method.
@amstilp amstilp marked this pull request as ready for review May 31, 2024 21:29
@amstilp amstilp merged commit 4cc0e16 into main May 31, 2024
14 checks passed
@amstilp amstilp deleted the feature/unlink-account-from-user branch May 31, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to "unlink" an account from a user
1 participant