Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instability in RBM #37

Merged
merged 29 commits into from
May 7, 2018
Merged

Fix instability in RBM #37

merged 29 commits into from
May 7, 2018

Conversation

YifanCheng
Copy link
Collaborator

Numerical instability was found in river temperature and reservoir temperature simulation results in RBM. In this PR, the numerical instability problem is fixed. Main changes made are concluded as follows:

  • Add estimation of errors caused by numerical method (river temperature and reservoir temperature)
  • Set up minimum wind speed to be 1m/s
  • Apply dynamic timesteps in calculating reservoir temperature based on the numerical error estimation
  • Set the minimum depth to be 5 feet

rniemeyer07 and others added 29 commits July 19, 2017 13:32
@rniemeyer07
inserted a comment at top of Begin.f90 to verify PR
fd21414
@rniemeyer07
small changes to read_forcing.f90 to read in energy and flow files
2253a6a
@rniemeyer07
removed ^M carriage returns
f16833b
@rniemeyer07
updated rbm10, added Block_Reservoir
f5f2430
@rniemeyer07
added Block_Reservoir, added variables to read in reservoir data, add…
3352fb0 
…ed if loop in Systmm
Merge branch 'RBM_res_develop' of https://github.com/UW-Hydro/RBM int…
33593d8 
…o RBM_res_develop
fix small bugs in RBM in particle tracking
965ade8
fix minor error in particle tracking branch
8e22071
test for instability in RBM
0ad3424 
add some output sentence to check the output
calculate the error aroused because of numerical schemes implemented
2a98174
add estimation of second order error
3d32e8f
comment out printing statement (for test)
ea88e91
add output filtering
06acd9a
Fix the number of segments output for each grid cell.
b680dff
fix output statement
6b552fa
debug - allocated space is not sufficient for variables in Block_Hydr…
f7e0c06 
…o.f90
git rid of the speeding up in make file
0ff5c18
experiment for temperature spikes in model simulation
d4be946
set the minimum wind speed to be 1 m/s
10e5b6e
fix small bug for wind speed threshold
71ecae4
check reservoir temperature instability
f358f92
add Error_estimate subroutine
518aabb 
based on numerical error to adjust the timestep to calculate stream temperature
fix bugs in dynamic time step to calculate reservoir temperature
25d0191 
this bug is resulted from reservoir storage calculation.
Set the initial storage to be 95% of reservoir capacity
d80444a
1) calculate equilibrium temperature
5dcc50d 
2) estimate how long it will take to reach equilibrium
set the minimum river depth to be 5 feet
b7c132e
bug fix for reservoir storage data
963319e
clean up makefile
7c385a3
Merge branch 'test_instability_to_delete' into RBM_res_develop
c1a667f
@YifanCheng
Copy link
Collaborator Author

This pull request was merged as this is a stable version of RBM-2L.

@YifanCheng YifanCheng merged commit 42baefd into UW-Hydro:RBM_res_develop May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YifanCheng @rniemeyer07