constrain_fraction default value #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line that recommended to set constrain_fractions to False was changed to suggest default value to True
jhamman
reviewed
Sep 12, 2018
docs/user-guide/parameters.md
Outdated
| @@ -146,7 +146,7 @@ A csv file that describes the routing of flow to the edge of the origin grid cel | |||
| - Type: bool | |||
| - Valid values: True, False | |||
|
|
|||
| Note: *True when routing to coastal grid cells, else False.* | |||
| *Default: True* | |||
There was a problem hiding this comment.
There is no default value here. Users will have to specify one way or another. I think we want to say something like:
Note: In most cases, this should be set to True unless routing is being done to nested basins, in which case, this should be set to False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line that recommended to set constrain_fractions to False was changed to suggest default value to True