Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release 4.2 #156

Closed
2 tasks done
bartnijssen opened this issue Oct 16, 2014 · 8 comments
Closed
2 tasks done

release 4.2 #156

bartnijssen opened this issue Oct 16, 2014 · 8 comments
Assignees
@jhamman
Milestone
4.2

Comments

@bartnijssen
Copy link
Member

4.2 is code-complete (i.e. no new features, additions, etc). The only outstanding issues are

I have moved the release date till the end of October to allow @jhamman time to fix the water balance error and @tbohn to provide documentation for the new features.

No commits other than the bug fix for #147 will be made to 4.2.

This issue can be closed when 4.2. is released.

I will now go ahead with the code reformat from issue #48 and the reorganization from issue #7. I will update the VIC/develop and VIC/dev_5.0 branches accordingly (eventually VIC/dev_5.0 will be deleted).
@bartnijssen bartnijssen added this to the 4.2 milestone Oct 16, 2014
@tbohn
Copy link
Contributor

tbohn commented Oct 16, 2014

I hate to say this, but between now and the end of the month, I doubt I
will have time to update documentation. I am organizing a session and a
workshop at the Mexican Geophysical Union meeting the first week of
November. I am also presenting at both of these and still have to complete
the analysis for these. If you would like me to help document, please
delay the release date until mid-November.

Thanks,
Ted

On Thu, Oct 16, 2014 at 2:46 PM, Bart Nijssen notifications@github.com
wrote:

4.2 is code-complete (i.e. no new features, additions, etc). The only
outstanding issues are

I have moved the release date till the end of October to allow @jhamman
https://github.com/jhamman time to fix the water balance error and
@tbohn https://github.com/tbohn to provide documentation for the new
features.

No commits other than the bug fix for #147
#147 will be made to 4.2.

This issue can be closed when 4.2. is released.

I will now go ahead with the code reformat from issue #48
#48 and the reorganization from
issue #7 #7. I will update the
VIC/develop and VIC/dev_5.0 branches accordingly (eventually VIC/dev_5.0
will be deleted).

—
Reply to this email directly or view it on GitHub
#156.

@bartnijssen
Copy link
Member Author

I hate it too ...

On Oct 16, 2014, at 2:53 PM, Ted Bohn notifications@github.com wrote:

I hate to say this, but between now and the end of the month, I doubt I
will have time to update documentation. I am organizing a session and a
workshop at the Mexican Geophysical Union meeting the first week of
November. I am also presenting at both of these and still have to complete
the analysis for these. If you would like me to help document, please
delay the release date until mid-November.

Thanks,
Ted

On Thu, Oct 16, 2014 at 2:46 PM, Bart Nijssen notifications@github.com
wrote:

4.2 is code-complete (i.e. no new features, additions, etc). The only
outstanding issues are

I have moved the release date till the end of October to allow @jhamman
https://github.com/jhamman time to fix the water balance error and
@tbohn https://github.com/tbohn to provide documentation for the new
features.

No commits other than the bug fix for #147
#147 will be made to 4.2.

This issue can be closed when 4.2. is released.

I will now go ahead with the code reformat from issue #48
#48 and the reorganization from
issue #7 #7. I will update the
VIC/develop and VIC/dev_5.0 branches accordingly (eventually VIC/dev_5.0
will be deleted).

—
Reply to this email directly or view it on GitHub
#156.

—
Reply to this email directly or view it on GitHub.

@tbohn
Copy link
Contributor

tbohn commented Oct 16, 2014

You can still freeze the code without releasing the model... Is anybody
clamoring to get 4.2 (who can't just download it from GitHub anyway)?

On Thu, Oct 16, 2014 at 3:57 PM, Bart Nijssen notifications@github.com
wrote:

I hate it too ...

On Oct 16, 2014, at 2:53 PM, Ted Bohn notifications@github.com wrote:

I hate to say this, but between now and the end of the month, I doubt I
will have time to update documentation. I am organizing a session and a
workshop at the Mexican Geophysical Union meeting the first week of
November. I am also presenting at both of these and still have to
complete
the analysis for these. If you would like me to help document, please
delay the release date until mid-November.

Thanks,
Ted

On Thu, Oct 16, 2014 at 2:46 PM, Bart Nijssen notifications@github.com

wrote:

4.2 is code-complete (i.e. no new features, additions, etc). The
only
outstanding issues are

I have moved the release date till the end of October to allow
@jhamman
https://github.com/jhamman time to fix the water balance error and
@tbohn https://github.com/tbohn to provide documentation for the
new
features.

No commits other than the bug fix for #147
#147 will be made to 4.2.

This issue can be closed when 4.2. is released.

I will now go ahead with the code reformat from issue #48
#48 and the reorganization
from
issue #7 #7. I will update
the
VIC/develop and VIC/dev_5.0 branches accordingly (eventually
VIC/dev_5.0
will be deleted).

—
Reply to this email directly or view it on GitHub
#156.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#156 (comment).

@bartnijssen
Copy link
Member Author

Yes, but these are changes that you wanted to have in 4.2. Other than you, nobody is using them, but they are now in 4.2 and in the development branches that are leading to 5.0, which is why I want them documented. Having them there without documentation does not make sense. We could have punted on them 6 months ago and you could have just implemented them on your own branch which could have been merged later by you. Suggesting that they should be part of 4.2 and then holding up the release because you don't have time to write documentation (which could have been written months ago when you committed the changes) is unfortunate ... We're all busy ...

On Oct 16, 2014, at 4:21 PM, Ted Bohn notifications@github.com wrote:

You can still freeze the code without releasing the model... Is anybody
clamoring to get 4.2 (who can't just download it from GitHub anyway)?

On Thu, Oct 16, 2014 at 3:57 PM, Bart Nijssen notifications@github.com
wrote:

I hate it too ...

On Oct 16, 2014, at 2:53 PM, Ted Bohn notifications@github.com wrote:

I hate to say this, but between now and the end of the month, I doubt I
will have time to update documentation. I am organizing a session and a
workshop at the Mexican Geophysical Union meeting the first week of
November. I am also presenting at both of these and still have to
complete
the analysis for these. If you would like me to help document, please
delay the release date until mid-November.

Thanks,
Ted

On Thu, Oct 16, 2014 at 2:46 PM, Bart Nijssen notifications@github.com

wrote:

4.2 is code-complete (i.e. no new features, additions, etc). The
only
outstanding issues are

I have moved the release date till the end of October to allow
@jhamman
https://github.com/jhamman time to fix the water balance error and
@tbohn https://github.com/tbohn to provide documentation for the
new
features.

No commits other than the bug fix for #147
#147 will be made to 4.2.

This issue can be closed when 4.2. is released.

I will now go ahead with the code reformat from issue #48
#48 and the reorganization
from
issue #7 #7. I will update
the
VIC/develop and VIC/dev_5.0 branches accordingly (eventually
VIC/dev_5.0
will be deleted).

—
Reply to this email directly or view it on GitHub
#156.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#156 (comment).

—
Reply to this email directly or view it on GitHub.

@tbohn
Copy link
Contributor

tbohn commented Oct 16, 2014

I understand your point. In the future, I will prepare the documentation
at the time of check-in.

I will try to get the documentation finished by the end of the month.

On Thu, Oct 16, 2014 at 4:38 PM, Bart Nijssen notifications@github.com
wrote:

Yes, but these are changes that you wanted to have in 4.2. Other than you,
nobody is using them, but they are now in 4.2 and in the development
branches that are leading to 5.0, which is why I want them documented.
Having them there without documentation does not make sense. We could have
punted on them 6 months ago and you could have just implemented them on
your own branch which could have been merged later by you. Suggesting that
they should be part of 4.2 and then holding up the release because you
don't have time to write documentation (which could have been written
months ago when you committed the changes) is unfortunate ... We're all
busy ...

On Oct 16, 2014, at 4:21 PM, Ted Bohn notifications@github.com wrote:

You can still freeze the code without releasing the model... Is anybody
clamoring to get 4.2 (who can't just download it from GitHub anyway)?

On Thu, Oct 16, 2014 at 3:57 PM, Bart Nijssen notifications@github.com

wrote:

I hate it too ...

On Oct 16, 2014, at 2:53 PM, Ted Bohn notifications@github.com
wrote:

I hate to say this, but between now and the end of the month, I
doubt I
will have time to update documentation. I am organizing a session
and a
workshop at the Mexican Geophysical Union meeting the first week of
November. I am also presenting at both of these and still have to
complete
the analysis for these. If you would like me to help document,
please
delay the release date until mid-November.

Thanks,
Ted

On Thu, Oct 16, 2014 at 2:46 PM, Bart Nijssen <
notifications@github.com>

wrote:

4.2 is code-complete (i.e. no new features, additions, etc). The
only
outstanding issues are

I have moved the release date till the end of October to allow
@jhamman
https://github.com/jhamman time to fix the water balance error
and
@tbohn https://github.com/tbohn to provide documentation for
the
new
features.

No commits other than the bug fix for #147
#147 will be made to 4.2.

This issue can be closed when 4.2. is released.

I will now go ahead with the code reformat from issue #48
#48 and the
reorganization
from
issue #7 #7. I will
update
the
VIC/develop and VIC/dev_5.0 branches accordingly (eventually
VIC/dev_5.0
will be deleted).

—
Reply to this email directly or view it on GitHub
#156.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#156 (comment).

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#156 (comment).

@bartnijssen
Copy link
Member Author

Thank you - Gracias - Merci - Danke - Dankjewel - Grazie - Origato

On Oct 16, 2014, at 4:49 PM, Ted Bohn notifications@github.com wrote:

I understand your point. In the future, I will prepare the documentation
at the time of check-in.

I will try to get the documentation finished by the end of the month.

On Thu, Oct 16, 2014 at 4:38 PM, Bart Nijssen notifications@github.com
wrote:

Yes, but these are changes that you wanted to have in 4.2. Other than you,
nobody is using them, but they are now in 4.2 and in the development
branches that are leading to 5.0, which is why I want them documented.
Having them there without documentation does not make sense. We could have
punted on them 6 months ago and you could have just implemented them on
your own branch which could have been merged later by you. Suggesting that
they should be part of 4.2 and then holding up the release because you
don't have time to write documentation (which could have been written
months ago when you committed the changes) is unfortunate ... We're all
busy ...

On Oct 16, 2014, at 4:21 PM, Ted Bohn notifications@github.com wrote:

You can still freeze the code without releasing the model... Is anybody
clamoring to get 4.2 (who can't just download it from GitHub anyway)?

On Thu, Oct 16, 2014 at 3:57 PM, Bart Nijssen notifications@github.com

wrote:

I hate it too ...

On Oct 16, 2014, at 2:53 PM, Ted Bohn notifications@github.com
wrote:

I hate to say this, but between now and the end of the month, I
doubt I
will have time to update documentation. I am organizing a session
and a
workshop at the Mexican Geophysical Union meeting the first week of
November. I am also presenting at both of these and still have to
complete
the analysis for these. If you would like me to help document,
please
delay the release date until mid-November.

Thanks,
Ted

On Thu, Oct 16, 2014 at 2:46 PM, Bart Nijssen <
notifications@github.com>

wrote:

4.2 is code-complete (i.e. no new features, additions, etc). The
only
outstanding issues are

I have moved the release date till the end of October to allow
@jhamman
https://github.com/jhamman time to fix the water balance error
and
@tbohn https://github.com/tbohn to provide documentation for
the
new
features.

No commits other than the bug fix for #147
#147 will be made to 4.2.

This issue can be closed when 4.2. is released.

I will now go ahead with the code reformat from issue #48
#48 and the
reorganization
from
issue #7 #7. I will
update
the
VIC/develop and VIC/dev_5.0 branches accordingly (eventually
VIC/dev_5.0
will be deleted).

—
Reply to this email directly or view it on GitHub
#156.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#156 (comment).

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#156 (comment).

—
Reply to this email directly or view it on GitHub.

@jhamman
Copy link
Member

jhamman commented Nov 19, 2014

All the issues for 4.2 have now been closed. I will create tags for both the source code and documentation in the morning. Then, tomorrow afternoon, provided everything goes well, I will send an email to the VIC users group announcing the release.

@bartnijssen
Copy link
Member Author

Excellent

On Nov 18, 2014, at 5:04 PM, Joe Hamman notifications@github.com wrote:

All the issues for 4.2 have now been closed. I will create tags for both the source code and documentation in the morning. Then, tomorrow afternoon, provided everything goes well, I will send an email to the VIC users group announcing the release.

—
Reply to this email directly or view it on GitHub.

@jhamman jhamman closed this as completed Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhamman jhamman

Labels
None yet
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
3 participants
@bartnijssen @jhamman @tbohn