-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of user_def.h #21
Comments
Ted to scope out what is easy to remove (these will become part of 4.2) and what is hard (VIC 5.0). This issue will likely be split into multiple new issues (at which time this one can be closed). |
Here are my recommendations. In all cases, we can do something for 4.2, so that user_def.h potentially could be removed for 4.2. My recommendations are for 4.2 unless otherwise stated.
|
Note: the contents of snow.h could also potentially be moved to vicNl_def.h; the contents of LAKE.h could be moved to vicNl.h; and some/all of the contents of global.h could be moved to vicNl_def.h. This is mainly for ease of dealing with the code. |
Ease is good. However, if they are functionally different pieces of the code it might be good to keep them separate. Originally snow.h was separate, because it was basically the same snow code as DHSVM and it made it easier to upgrade compare. These are a bit different than the user_def.h cases and I think a case could be made to keep them separate. Bart On Dec 18, 2013, at 10:12 AM, Ted Bohn notifications@github.com wrote:
|
If there are no objections to my recommendations, I can go ahead and start making those changes. Let me know if you would like me to break any of the individual options out into separate issues (and assign them to myself). |
As mentioned - I am not sure that we want to get rid of snow.h at this time, but please proceed with user_def.h. On Dec 22, 2013, at 3:41 PM, Ted Bohn notifications@github.com wrote:
|
@tbohn, at a minimum, lets try to put each change to user_def.h variables in their own commits. They all can live under this issue. |
A couple questions:
|
CRITICAL 50 Bart On Dec 26, 2013, at 4:50 PM, Ted Bohn notifications@github.com wrote:
|
OK, how about this: I will handle VERBOSE in 2 stages. The first stage will simply be to transfer the VERBOSE precompile definition from user_def.h to vicNl_def.h, so that user_def.h can be removed and this issue can be closed. For the second stage, I'll create a separate issue to create consistent logging. VERBOSE will go away as part of the second stage. Any objections? |
No objections
|
One last question. Regarding NO_REWIND, I suggested two options: either move it to the options_struct in vicNl_def.h as a run-time option, or getting rid of it altogether. I'm leaning towards getting rid of it, since it seems like our parameter files are always set up so that all grid cells are present and appear in the same order. It would just fall on the user to set up their files correctly. Any objections? |
As long as the program aborts if it cannot find the next grid cell that is fine with me. I'd like to move my parameter files to netcdf anyway (eventually), where this would not be an issue. We may also write a little preprocessir script that properly checks (and reorders the files if need be). Bart
|
These changes are now complete. User_def.h is now gone (for details, see my pull request). I am creating 2 new issues (each one much smaller than this one was):
|
This code update also addresses issue #38. |
Now that the pull request has been executed, I'm closing this issue. |
Description - Either remove these options or move them to global parameter file. Remove #ifdef’s from code. Remove VIC’s –o flag.
Optional? - No
The text was updated successfully, but these errors were encountered: