-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing LOG_MATRIC option #65
Comments
@tbohn or @bartnijssen , do either of you have any thoughts thoughts on this. The documentation for the option is sparse but this is what I've been able to find.
The option is used twice in 343 if (options.LOG_MATRIC) {
344 for( lindex = 0; lindex < options.Nlayer; lindex++ ) {
345 if( (tmp_liq = liq[lindex] - evap[lindex][frost_area]) < resid_moist[lindex] )
346 tmp_liq = resid_moist[lindex];
347 if(tmp_liq > resid_moist[lindex])
348 matric[lindex] = soil_con->bubble[lindex] * pow( (tmp_liq - resid_moist[lindex]) / (soil_con->max_moist[l 348 index] - resid_moist[lindex]), -b[lindex]);
349 else
350 matric[lindex] = HUGE_RESIST;
351 }
352 } ...and... 366 if (options.LOG_MATRIC) {
367 avg_matric = pow( 10, (soil_con->depth[lindex+1] * log10(fabs(matric[lindex])) + soil_con->depth[lindex] 367 * log10(fabs(matric[lindex+1]))) / (soil_con->depth[lindex] + soil_con->depth[lindex+1]) );
368 tmp_liq = resid_moist[lindex] + ( soil_con->max_moist[lindex] - resid_moist[lindex] ) * pow( ( avg_matric 368 / soil_con->bubble[lindex] ), -1/b[lindex] );
369 } I see three options moving forward with this issue:
|
The way I see it, it was an experimental option that was never fully tested Meanwhile, option 1 requires more effort on our parts as well, for So I'm leaning towards option 2 (removing it). Ted On Thu, Sep 25, 2014 at 8:21 AM, Joe Hamman notifications@github.com
|
The above PR (#143) is not set in stone but does illustrate how easy it is to remove the option entirely. |
Removed by merging PR #143 |
I'm reopening since I'm seeing a few pieces of the LOG_MATRIC option still in the code. |
close again via 1b7d23a |
Preliminary tests indicate that the LOG_MATRIC run-time option (formerly the LOW_RES_MOIST compile-time option in user_def.h) has little effect.
The preliminary tests were conducted at a few grid cells in the Columbia Basin. It would be nice to conduct further tests over a wider variety of environments to confirm whether this option is necessary.
If it is deemed unnecessary, its removal should be relatively straightforward, as it primarily affects runoff.c.
The text was updated successfully, but these errors were encountered: