Unused functions

[bartnijssen]

This is based on b3afdc4

A number of functions are never used in VIC - we should consider removing all of these (to make code maintenance easier), especially since they will be preserved in the repo anyway.

If they are removed individual issues, commits, tests and pull requests should be created for all of them (or at least grouped by a common theme). In this issue I am just listing the unused functions:

calc_atmos_energy_bal.c -- remove if comment can be deleted

solve_atmos_moist_bal() # commented out in calc_atmos_energy_bal.c:calc_atmos_energy_bal()
error_calc_atmos_moist_bal()
error_print_atmos_moist_bal() # used in error_calc_atmos_moist_bal() -- see previous line

calc_veg_params.c -- see issue #88

calc_veg_displacement()
calc_veg_roughness()

calc_cloud_cover_fraction.c -- see issue #81

calc_cloud_cover_fraction()

compute_dz.c -- issue #87

compute_dz()

initialize_lake.c -- @tbohn: Should these be kept?

get_depth_from_sarea()
ice_depth()

initialize_new_storm.c -- will be removed as part of dist_prec, see issue #22

initialize_new_storm()

modify_Ksat.c -- @tbohn: Should these be kept?

exp_interp() # commented out in initialize_model_state.c:initial_model_state()
modify_Ksat()

write_snow_data.c -- see issue #89

write_snow_data()

write_soilparam.c -- see issue #89

write_soilparam()

write_vegparam.c -- see issue #89

write_vegparam()

[tbohn]

I am removing those function s associated with the dist_prec option as part of that commit. this includes the four functions with ”storm ” in the name.

T-Mobile. America’s First Nationwide 4G Network

----- Reply message -----
From: "bartnijssen" notifications@github.com
To: "UW-Hydro/VIC" VIC@noreply.github.com
Subject: [VIC] Unused functions (#86)
Date: Tue, Mar 25, 2014 5:40 pm
This is based on b3afdc4

A number of functions are never used in VIC - we should consider removing all of these (to make code maintenance easier), especially since they will be preserved in the repo anyway.

If they are removed individual issues, commits, tests and pull requests should be created for all of them (or at least grouped by a common theme). In this issue I am just listing the unused functions:

calc_atmos_energy_bal.c

solve_atmos_moist_bal() # commented out in calc_atmos_energy_bal.c:calc_atmos_energy_bal()
error_calc_atmos_moist_bal()
error_print_atmos_moist_bal() # used in error_calc_atmos_moist_bal() -- see previous line

calc_veg_params.c

calc_veg_displacement()
calc_veg_roughness()

calc_cloud_cover_fraction.c -- see issue #81

calc_cloud_cover_fraction()

compute_dz.c

compute_dz()

... to be continued ...

—
Reply to this email directly or view it on GitHub.