Feature/logging #173
Merged
Feature/logging #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge now or wait for the remaining pieces? |
|
That's the question. We should discuss how we want to delineate stderr and stout, errors, and exit codes. Currently there is quite the hodgepodge. |
added 3 commits
December 5, 2014 23:02
- Print statements now go to the global FILE stream "LOG_DEST" - Logging and error handling is controlled via macros in vic_log.h - All references to vicerror() and nrerror() have been replaced with log_err()
…ll initialize_log() before a log function is used and setup_logging() after the global parameter file is read
|
Alright, this is ready. Was tested on for both drivers, logging to stderr and a logfile. |
|
closes #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working now.
There are two steps left to fully use the added functionality.
printfstatements with the appropriate log functionsdrivers/shared/vic_log.cNeither of these steps need to be done immediately and the logging functions work out of the box with this PR.