Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/testing vic5 #190

Merged
merged 4 commits into from
Jan 20, 2015
Merged

Feature/testing vic5 #190

merged 4 commits into from
Jan 20, 2015

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Jan 13, 2015

This is the start of the VIC test module.

Notable Features

  1. Travis is now compiling using gcc and clang, builds are passing for both compilers.
  2. All tests are run from the run_tests.py script.
  3. No changes were made to the VIC source code
  4. The directory tests/test_data/will not be included in the repository but is available for preview here. I'm still adding a few pieces to this but the general structure is now in place.
  5. Currently, the system tests are the most built out but with the test structure I've put together, more can be easily added.

Test Module Structure:

  1. unit: function level tests.
  2. system: tests that aim to address model runtime issues. These tests are generally very quick.
  • configuration errors - tests that address model startup and error checking.
  • restart: tests that address model state and restart capacity.
  • I/O: tests that address model input and output functionality.
    • forcings come out the way the come in
    • parameter files are appropriately read in allocated.
  1. science: tests that aim to assess the model's scientific skill. Many of these tests are compared to observations of some kind.
  2. examples: a set of examples that users may download and run.
  3. release: longer, full domain simulations performed prior to release demonstrating model output for a final release.

Areas in need of further development:

  • Science Tests: comparisons with observations
  • Image Mode Driver Tests: currently all tests use the classic driver
  • Standard test comparing image and classic drivers.
  • Tests datasets for lesser used options:
    • Blowing snow,
    • Precipitation correction,
    • Lakes and wetlands, and
    • Carbon cycle.

This could be merged now or we could wait until we've added more tests. Since there are no changes to the source code of VIC, the only downside to merging now is that there will need to be more pull requests in the future.

fixes #79.

@bartnijssen
Copy link
Member

No code review at this stage, but will accept pull request to get this started and since it lives in its own directories

bartnijssen added a commit that referenced this pull request Jan 20, 2015
@bartnijssen bartnijssen merged commit 744c0c1 into UW-Hydro:develop Jan 20, 2015
@jhamman jhamman deleted the feature/testing_vic5 branch August 25, 2015 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants