-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up ascii header #227
Conversation
…eader does not include a comment for the line containing the variable names. An example of the new header format: # SIMULATION: ./test_fluxes_45.000_23.500.txt # MODEL_VERSION: VIC.5.0.beta # ALMA_UNITS: True YEAR MONTH DAY SECOND OUT_PREC OUT_VP OUT_WIND Part one of GH#204
Is there an issue that this pertains to? - this will break compatibility for anyone that has set up an automated processing stream assuming the old VIC files, so I assume there is an option to turn this on (or off) |
dmy->year, dmy->month, dmy->day, dmy->dayseconds); | ||
fprintf(out_data_files[file_idx].fh, "# ALMA_OUTPUT: %d\n", | ||
tmp_ALMA_OUTPUT); | ||
fprintf(out_data_files[file_idx].fh, "# NVARS: %zu\n", Nvars); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to remove existing fields like NVARS
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't fix.
Issue is #204 |
OK - thanks - then that just leave the line comments (no need to redo the discussion we already had on this - thx for including the issue number) |
Just say when the PR is complete and comment on the individual line comments with "won't fix" if you are not planning to change them. |
Just for backstory - the NVARS bit was for convenience, so a processing Ted On Fri, Jul 24, 2015 at 8:32 AM, Bart Nijssen notifications@github.com
|
This is ready to merge. Just to show the fully tested output: Daily timestep
Hourly timestep
|
@jhamman: Can you resolve the conflicts before I merge the PR? |
Okay - merge conflicts have been resolved. |
example of new header format: