Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table updates #106

Merged
merged 28 commits into from
Jan 23, 2024
Merged

Table updates #106

merged 28 commits into from
Jan 23, 2024

Conversation

CannonLock
Copy link
Collaborator

No description provided.

@CannonLock
Copy link
Collaborator Author

@davenquinn Don't merge, last commit is not a great one. Lets discuss at 1.

@davenquinn
Copy link
Member

davenquinn commented Jan 12, 2024

Awesome ish.
Just focusing on the front page:

  • Does not work in dark mode
  • You lost the numbers, which are important for us (internally) as a quick reference. There should be some way from that page to get the ID numbers or the slugs. And the lower rows without metadata have no way to see which map you're looking at
  • You're using a "log-out" icon for a "log-in" action
  • If you do link cards, ideally the whole card should be clickable for quick navigation
  • The toolbar should not scroll with the page (although the whole concept of having a toolbar on this page is debatable)
  • Especially now that the page takes about 300% of the vertical space of the previous version, the sort by primary key inevitably puts the most interesting maps (for editing) at the bottom

Overall, the login/logout functionality is needed, but I think this is a bit of a lateral move in terms of effective user interface TBH.

@davenquinn
Copy link
Member

In the future, it may be useful to separate "design" and "functionality"-oriented PRs to the extent possible.

@davenquinn
Copy link
Member

davenquinn commented Jan 12, 2024

Also, having a separate entry page for map editing that puts the login front and center, and then lists only/primarily "incomplete" maps would be more ideal, I think.

This could essentially be the root of the /maps/ingestion application or something

@davenquinn
Copy link
Member

I'm also getting 500 errors on clicking any of the newly imported maps. Could it be that the fields were not prepared for them properly?

@CannonLock CannonLock merged commit 18ee779 into main Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants