This repository has been archived by the owner on May 4, 2022. It is now read-only.
cleaning up filesystem errors on build-static #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
approved these changes
May 1, 2017
| mkdirp('uw-frame-static/target/css/themes/', function (err) { | ||
| if (err) throw error; | ||
| mkdirp('uw-frame-static/target/css/themes/', function (error) { | ||
| if (error) throw error; |
There was a problem hiding this comment.
could error be confused with Error here?
There was a problem hiding this comment.
I want to trust that Error would be immediately noticeable due to classes starting with capitals by convention. If someone saw Error and not Error() or new Error() that should be picked up during review.
There was a problem hiding this comment.
Got it, you are expecting Google code style's new-cap lint rule to catch this.
tools/uw-frame-static/build.js
Outdated
| @@ -12,9 +12,12 @@ var exec_handler = function(error, stdout, stderr) { | |||
|
|
|||
| var mkdirp = require('mkdirp'); | |||
| var copy = require('recursive-copy'); | |||
| var copyOptions = { | |||
There was a problem hiding this comment.
assuming Node.js 4+ is the target run time, should this be a const?
There was a problem hiding this comment.
yup. and we're using const elsewhere in the file. I'll update the file to use it consistently.
apetro
approved these changes
May 2, 2017
vertein
approved these changes
May 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to frame weren't showing up when I ran static:dev, so I went through and fixed the build script.
Standardized error throwing, copy now overwrites.
Contributor License Agreement adherence: