Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab status page broken if used with https #76

Closed
LOZORD opened this issue Mar 14, 2016 · 17 comments
Closed

Lab status page broken if used with https #76

LOZORD opened this issue Mar 14, 2016 · 17 comments

Comments

@LOZORD
Copy link
Member

LOZORD commented Mar 14, 2016

https://uw-upl.github.io/#/lab

Here's the error message:

Mixed Content: The page at 'https://uw-upl.github.io/#/lab' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://eris.upl.cs.wisc.edu:1312/lab-status'. This request has been blocked; the content must be served over HTTPS.

So basically, do we want to add https to eris?

@Squeakrats
Copy link
Contributor

Uh the URL in code can prob just have an s added to it.

@LOZORD
Copy link
Member Author

LOZORD commented Mar 14, 2016

@Squeakrats do you mind taking care of it?

@Squeakrats
Copy link
Contributor

I'll try

@LOZORD
Copy link
Member Author

LOZORD commented Apr 12, 2016

🐫

1 similar comment
@spwilson2
Copy link
Contributor

🐫

@Squeakrats Squeakrats reopened this Jun 8, 2016
@Squeakrats
Copy link
Contributor

Squeakrats commented Jun 8, 2016

Oh yea I forgot about this. I believe the issue was that I needed to create an Https Cert? I probably should know this but does anyone know if thats how that works? Im pretty sure the issue was https pages cant do anything over http (which the lab status was) and to make the lab status https you need https certs.

@Squeakrats
Copy link
Contributor

  • I also think adding it is more of a hassle than its worth. Adding https doesn't really get us anything.

@Squeakrats
Copy link
Contributor

Leo would you have a problem with just re-directing https to http?

@spwilson2
Copy link
Contributor

spwilson2 commented Jun 8, 2016

Is there any way we could redirect to an https page that warns about going to unencrypted http beforehand? I reaally don't like the idea of redirecting from https to http - especially without a warning. Although anyone who really cares should just be using https everywhere

@Squeakrats
Copy link
Contributor

Probably. But like what content do we have that would need to be over https?

@spwilson2
Copy link
Contributor

It's mostly about the principle to me, if you really want we can discuss at coord meeting tho

@Squeakrats
Copy link
Contributor

suar

@LOZORD
Copy link
Member Author

LOZORD commented Jun 8, 2016

Redirecting is a non-optimal solution. Up to you guys.

On Wednesday, June 8, 2016, Squeakrats notifications@github.com wrote:

suar


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#76 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADhFUVcsctpcQkIb_u0UrzVAmbBia6Hsks5qJh2OgaJpZM4HwRoZ
.

@LOZORD
Copy link
Member Author

LOZORD commented Jun 8, 2016

FYI: https://github.com/blog/2186-https-for-github-pages

On Wednesday, June 8, 2016, Leo Rudberg ljrudberg@gmail.com wrote:

Redirecting is a non-optimal solution. Up to you guys.

On Wednesday, June 8, 2016, Squeakrats <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

suar


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#76 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADhFUVcsctpcQkIb_u0UrzVAmbBia6Hsks5qJh2OgaJpZM4HwRoZ
.

@spwilson2
Copy link
Contributor

As far as I know the problem isn't on the github side, but on the eris
side. Github HTTPS is working fine it's the trying to get lab status from
eris over HTTPS that's the issue. (I think)
On Jun 8, 2016 3:37 PM, "Leo Rudberg" notifications@github.com wrote:

FYI: https://github.com/blog/2186-https-for-github-pages

On Wednesday, June 8, 2016, Leo Rudberg ljrudberg@gmail.com wrote:

Redirecting is a non-optimal solution. Up to you guys.

On Wednesday, June 8, 2016, Squeakrats <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

suar


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
#76 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe/ADhFUVcsctpcQkIb_u0UrzVAmbBia6Hsks5qJh2OgaJpZM4HwRoZ

.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#76 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AK9rOMJdHQmnR0OPSRPAvrSO4fMl8HjZks5qJygfgaJpZM4HwRoZ
.

@Squeakrats
Copy link
Contributor

Yup I believe so too.

@WowSuchRicky
Copy link
Member

Merging with #110 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants