Improvements related to freedom-compatible interface for socks-to-rtc

[bemasc]

I accidentally merged the last pull request (#170) before all the comments were in, so this one will have to serve as a continuation.

[bemasc]

@trevj, @willscott, @iislucas, @ryscheng, this is the continuation of #170, on which you were cc'd or had commented.

[willscott]

👍 from me, but wait for consensus from @iislucas

[iislucas]

Comments from the review on Reviewable.io

Reviewed files:

• src/socks-to-rtc/socks-to-rtc.d.ts @ r1
• src/socks-to-rtc/socks-to-rtc.ts @ r1

---

LGTM (Playing with https://reviewable.io/ to write this review) 👍

---

[willscott]

@iislucas - I can't tell: was your only comment a ':+1:', or are there other comments made that I can't see?

[bemasc]

@iislucas, do you think I should also wait to hear from trevj@?

[iislucas]

Yes, that's my only comment! (This pull request is very minimal: it is
basically a couple of comment fixes and a type-fix. It doesn't need to be
reviewed more deeply - although the original should be looked at by Trevor
as he's the uproxy-networking owner).

On Sun, Dec 28, 2014 at 11:46 AM, Will notifications@github.com wrote:

@iislucas https://github.com/iislucas - I can't tell: was your only
comment a '[image: 👍]', or are there other comments made that I can't
see?

—
Reply to this email directly or view it on GitHub
#171 (comment)
.

Lucas Dixon | Google Ideas