Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify existing users that Google and Facebook social networks have changed #1928

Merged
merged 3 commits into from
Sep 28, 2015

Conversation

dborkan
Copy link
Contributor

@dborkan dborkan commented Sep 28, 2015

Notify existing users that Google and Facebook social networks have changed

New users of uProxy (those with hasSeenWelcome=false) will never see this notification - once they see the welcome screen, they will then have the new hasSeenGoogleAndFacebookChangedNotification flag set to true.

screen shot 2015-09-28 at 1 45 53 pm

Review on Reviewable

<!-- content is set using .innerHTML so that we can embed HTML in translations -->
</div>
<div style="text-align:center;">
<uproxy-button on-tap='{{ dismissGoogleAndFacebookChangedNotification }}'>OK</uproxy-button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit {{ "OK" | $$ }}

@lucyhe
Copy link
Contributor

lucyhe commented Sep 28, 2015

👍

dborkan added a commit that referenced this pull request Sep 28, 2015
Notify existing users that Google and Facebook social networks have changed
@dborkan dborkan merged commit 581cbed into dev Sep 28, 2015
@dborkan dborkan deleted the dborkan-notification branch September 28, 2015 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants