Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mzID output contains multiple SpectrumIdentificationResult tags for the same spectrum #45

Closed
524D opened this issue Oct 12, 2023 · 4 comments

Comments

@524D
Copy link

524D commented Oct 12, 2023

Hi,

When mzIdentML (mzID) output is selected, and Comet finds multiple identifications for the same spectrum, each identification is reported in a separate SpectrumIdentificationResult tag. This is seems not correct according to the mzID schema.
In the Comet output, each result is enclosed in both a SpectrumIdentificationResult and a SpectrumIdentificationItem tag. Identifications belonging to the same spectrum should however be grouped under the same SpectrumIdentificationResult.

This problem prevents Comet mzID files to be read by readMzIdData in R.

For completeness, there is another problem that prevents reading Comet output with readMzIdData, but that seems to be on the reader side.

I'm using Comet v2023.01.2

Best, Rob

@jke000
Copy link
Collaborator

jke000 commented Oct 12, 2023

Bob,

Thanks for reporting the issue. I'm never confident I'm writing valid mzIdentML files even if they pass the validator. I hopefully addressed both of these issues (SpectrumIdentificationResult and the "other" problem) with commits 5f6af8e and f4e0c37. For the "other" problem preventing reads by readMzIdData, I just got rid of that cvParam entry that doesn't seem useful and hopefully isn't required.

If you're willing to test the fix and need a compiled binary, let me know what OS you're using and I can compile a binary for you if helpful.

Jimmy

@524D
Copy link
Author

524D commented Oct 13, 2023

Hi Jimmy,

Thanks for your very quick reply. Of course it would be great if you could send me a test version, either Windows or Linux is fine. However, I can probably only test by October 24 since I'm not at work until then.

Best, Rob

@jke000
Copy link
Collaborator

jke000 commented Oct 19, 2023

Rob, you can find a Linux binary at http://proteomicsresource.washington.edu/dist/comet.2023020.linux.exe

@524D
Copy link
Author

524D commented Oct 24, 2023

Hi Jimmy,

The mzID output look good with the new version and also works perfectly with readMzIdData. Many thanks for the quick fix.

Rob

@524D 524D closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants