Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to File Transfer Client in Unity #17

Merged
merged 7 commits into from Feb 8, 2022
Merged

Conversation

ApolloZhu
Copy link
Collaborator

@ApolloZhu ApolloZhu commented Feb 7, 2022

Changelog

  • Added FirebaseFirestore and FirebaseStorage unity packages (version 8.8.0) as dependencies
  • Updated Android build identifier to match Firebase configuration
  • Implemented API for interacting with File Management Firebase backend:
    • A function to add text entry (for OCRed text)
    • Callback for responding to database updates (for dashboard), with a sample implementation that just logs changes
    • A function for getting download handle (so each file type can choose how to download)

Known Issues

Notes for Reviewer

This is again a gigantic PR 馃槩 but most files are just dependency binaries 馃. You can focus on:

  • Main
    • Boardless/Assets/Scripts/FirebaseServices.cs: code for interacting with Firestore database and file Storage
    • Boardless/Assets/Scenes/FirebaseServicesTest.unity: a basic scene for quickly testing FirebaseServices
  • Configs
    • Boardless/Assets/Plugins/Android/launcherTemplate.gradle: workarounds for known issues
    • Boardless/Assets/Plugins/Android/gradleTemplate.properties: Android Resolver Properties wants to have this file once I added the above grade config, not sure why but okay
    • Boardless/ProjectSettings/ProjectSettings.asset: Android bundle identifier.
  • Resources
    • Boardless/Assets/google-services.json: Firebase constants
    • Boardless/Assets/Plugins/Android/Firebase.androidlib/res/values/google-services.xml

      Generated using Assets/Firebase/Editor/generate_xml_from_google_services_json.py -i Assets/google-services.json -o Assets/Plugins/Android/Firebase.androidlib/res/values/google-services.xml

Why the Delay?

@ApolloZhu ApolloZhu added this to the MVP milestone Feb 7, 2022
@ApolloZhu ApolloZhu added this to In progress in Kanban via automation Feb 7, 2022
@ApolloZhu ApolloZhu self-assigned this Feb 7, 2022
@ApolloZhu ApolloZhu marked this pull request as ready for review February 8, 2022 00:10
Copy link
Collaborator

@penpenLoveUwU penpenLoveUwU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanban automation moved this from In progress to Review queue Feb 8, 2022
@ApolloZhu ApolloZhu merged commit 32e44ea into master Feb 8, 2022
Kanban automation moved this from Review queue to Done Feb 8, 2022
@ApolloZhu
Copy link
Collaborator Author

The MVP branch (WIP) confirmed this to be working, yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants