Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dropdown for adding transferred contents #20

Merged
merged 9 commits into from Feb 8, 2022
Merged

Conversation

ApolloZhu
Copy link
Collaborator

@ApolloZhu ApolloZhu commented Feb 8, 2022

Important

This merges into mvp instead of master, unless mvp has already been merged into master

Changelog

  • Shows an auto-updating list of files in any dropdown (currently added to the main dashboard)
  • On selecting plain text entries, add the text to the scene at a specified location (current 0, 2, 0)
  • The added text can be scaled and moved with controller like other generated objects

Known Issues

  • Can't use the whiteboard feature on the text (consistent with other generated objects)
  • Can't rotate the text (consistent with other generated objects)
  • Can't generate a display for other file types. This is expected and scheduled to be worked on in the next few weeks.

@ApolloZhu ApolloZhu added this to the Target Product milestone Feb 8, 2022
@ApolloZhu ApolloZhu self-assigned this Feb 8, 2022
@ApolloZhu ApolloZhu added this to In progress in Kanban via automation Feb 8, 2022
@ApolloZhu ApolloZhu changed the base branch from master to mvp February 8, 2022 07:42
@ApolloZhu ApolloZhu marked this pull request as ready for review February 8, 2022 07:42
Not sure where all of these fields are from
@ApolloZhu
Copy link
Collaborator Author

I've requested @ebanisadr's review since you'll need to implement displaying images on top of changes introduced in this PR. Let me know if I should alter anything for your needs that you anticipate.

@ApolloZhu ApolloZhu moved this from In progress to Review queue in Kanban Feb 8, 2022
@ApolloZhu ApolloZhu modified the milestones: Target Product, MVP Feb 8, 2022
@ebanisadr
Copy link
Collaborator

A problem I'm having is that generated objects that collide with each other get a velocity, and since they're not affected by gravity they tend to float away; see video.

edu.washington.cs.realitylab.xrcapstone22wi_team8-20220208-112752.mp4

@ApolloZhu
Copy link
Collaborator Author

@ebanisadr that is a problem with the MVP branch, which this PR doesn't change. unity-firebase branch should have the dropdown menu for selecting files and I'm not seeing that in your recording. Can you confirm you are building the correct branch?

@ApolloZhu
Copy link
Collaborator Author

@KH-Kyle is it safe to remove the RigidBody from primitive prefabs now? I believe that will fix the floating away issue (and you can commit directly to MVP after testing

@ebanisadr
Copy link
Collaborator

Good point, thought this was the PR to merge mvp into master.

@KH-Kyle
Copy link
Collaborator

KH-Kyle commented Feb 8, 2022

@KH-Kyle is it safe to remove the RigidBody from primitive prefabs now? I believe that will fix the floating away issue (and you can commit directly to MVP after testing

Yeah. We changed them during yesterday's meeting but it didn't update in the repo. I just update the mvp branch.

@ApolloZhu ApolloZhu merged commit 1ffc735 into mvp Feb 8, 2022
Kanban automation moved this from Review queue to Done Feb 8, 2022
@ApolloZhu ApolloZhu deleted the unity-firebase branch February 14, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants