Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect face area calculation for grids with Fill Values #280

Closed
philipc2 opened this issue Apr 18, 2023 · 0 comments · Fixed by #283
Closed

Incorrect face area calculation for grids with Fill Values #280

philipc2 opened this issue Apr 18, 2023 · 0 comments · Fixed by #283
Labels
bug Something isn't working
Milestone
Grid Topology

Comments

@philipc2
Copy link
Member

philipc2 commented Apr 18, 2023 •
edited

When decomposing faces into triangles for calculating the face area, faces that contain less than the maximum number of face nodes (a.k.a contain fill values) are not broken up correctly.
@philipc2 philipc2 added the bug Something isn't working label Apr 18, 2023
@philipc2 philipc2 linked a pull request Apr 18, 2023 that will close this issue
Face Area Fix, Face Dimension Variable, & Data Type Fix #283
Merged
@philipc2 philipc2 added this to the Grid Topology milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Grid Topology
Development

Successfully merging a pull request may close this issue.

Face Area Fix, Face Dimension Variable, & Data Type Fix UXARRAY/uxarray
1 participant
@philipc2