New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Face Area Fix, Face Dimension Variable, & Data Type Fix #283
Conversation
One concern is that we are bending the interpretation of
However, @rajeeja and I believe that this name is appropriate for this use case. Any other suggestions for a different name, other than I was considering |
@erogluorhan please review, this should fix the primal and dual mesh area calc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this really fast!
Overview
np.intp
instead ofnp.uintp
due tonumpy
indexing being written forintp
Mesh2_face_dimension
variable, used for storing the maximum number of non-fill-value vertices/nodes used for constructing a faceMesh2_face_dimension