Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX: MPAS attributes not stored correctly #275

Merged
merged 4 commits into from Apr 17, 2023
Merged

HOTFIX: MPAS attributes not stored correctly #275

merged 4 commits into from Apr 17, 2023

Conversation

philipc2
Copy link
Member

@philipc2 philipc2 commented Apr 15, 2023 •
edited

Additionally Hotfixes

  • Attributes were stored not being properly stored
  • Check for "is_periodic" attribute
  • Added test case for attributes

@philipc2 philipc2 changed the title HOTFIX: MPAS Attributes not stored correctly HOTFIX: MPAS attributes not stored correctly Apr 15, 2023
@philipc2 philipc2 self-assigned this Apr 15, 2023
rajeeja
rajeeja approved these changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@rajeeja rajeeja left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you catch this? Did a particular mesh file load failed?

_primal_to_ugrid -> calls set attrs -> looks for _is_periodic, this wasn't checked properly?

@philipc2
Copy link
Member Author

How did you catch this? Did a particular mesh file load failed?

_primal_to_ugrid -> calls set attrs -> looks for _is_periodic, this wasn't checked properly?

While working on the MPAS usage example notebook, it became clear the attributes were not being stored correctly. I'll add in a test case to check for this.

@philipc2 philipc2 requested a review from anissa111 April 16, 2023 14:08
@erogluorhan erogluorhan merged commit e86b47d into main Apr 17, 2023
14 checks passed
@erogluorhan erogluorhan deleted the philipc2/mpas-attr-hotfix branch June 9, 2023 21:42
@philipc2 philipc2 added this to the MPAS I/O Support milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeeja rajeeja rajeeja approved these changes

@erogluorhan erogluorhan erogluorhan approved these changes

@hongyuchen1030 hongyuchen1030 Awaiting requested review from hongyuchen1030

@anissa111 anissa111 Awaiting requested review from anissa111

Assignees

@philipc2 philipc2

Labels
None yet
Projects
None yet
Milestone
MPAS
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philipc2 @rajeeja @erogluorhan