-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topological Aggregations: (Node to Edge) and (Node to Face) #711
base: main
Are you sure you want to change the base?
Conversation
I'm going to pick this PR back up and address the changes that we've discussed in #724 Below are the following changes I'm going to make
This would look like the following in our API # assume some uxds with a `vorticity_200hPa` variable (node-centered)
uxds = ...
# standard xarray mean
uxds['vorticity_200hPa'].mean()
# topological (i.e. grid informed) mean, average of nodes stored on each face
uxds['vorticity_200hPa'].topological_mean(destination='face')
# topological (i.e. grid informed) mean, average of the nodes composed each edge.
uxds['vorticity_200hPa'].topological_mean(destination='edge') What do you think? I'd like to really move forward with this functionality and get the performance improvements in. |
Yes, all sounds good! |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I'd really appreciate some help proof reading and checking for any typos in the new functions that I added, especially in the docstrings. While reviewing, I also suggest looking over the user guide section I made for topological reductions. I'm really happy with how it turned out, and hope we can start making these sections for all of our functionality. https://uxarray--711.org.readthedocs.build/en/711/user-guide/topological-aggregations.html |
Closes #719 #718 #713 #712
Overview
mean
max
min
prod
sum
std
var
median
all
any