Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff Updates #728

Merged
merged 16 commits into from
May 8, 2024
Merged

Ruff Updates #728

merged 16 commits into from
May 8, 2024

Conversation

philipc2
Copy link
Member

@philipc2 philipc2 commented Mar 20, 2024 •
edited

Closes #729

Overview

  • Updates ruff-pre-commit to the latest version
  • Enabled linting & formatting on Jupyter Notebooks, with certain rules disabled to prevent the removal of hvplot imports, which would otherwise led to the notebooks not executing
  • Benchmark can be run locally using asv run --bench mpas_ocean from within the uxarray/benchmarks dir

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@philipc2 philipc2 changed the title DRAFT: Update Ruff DRAFT: Ruff Updates Mar 20, 2024
@philipc2 philipc2 linked an issue Mar 20, 2024 that may be closed by this pull request
Run Ruff Formatting & Linting on Notebooks #729
Closed
@philipc2 philipc2 self-assigned this Mar 22, 2024
@philipc2 philipc2 changed the title DRAFT: Ruff Updates Ruff Updates Mar 22, 2024
@philipc2 philipc2 marked this pull request as ready for review March 22, 2024 19:46
@philipc2 philipc2 added the documentation Improvements or additions to documentation label Mar 22, 2024
erogluorhan
erogluorhan reviewed Apr 1, 2024
View reviewed changes
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I feel like it does a good job, but there are a couple things I didn't like; in the comments below

docs/examples/001-working-with-unstructured-grids.ipynb Outdated Show resolved Hide resolved
ruff.toml Outdated Show resolved Hide resolved
@erogluorhan erogluorhan self-requested a review May 7, 2024 23:14
@philipc2 philipc2 merged commit 3107ae6 into main May 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erogluorhan erogluorhan erogluorhan approved these changes

Assignees

@philipc2 philipc2

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run Ruff Formatting & Linting on Notebooks
2 participants
@philipc2 @erogluorhan