Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASV Benchmarks for 480km and 120km MPAS Meshes #775

Merged
merged 8 commits into from
May 8, 2024

Conversation

philipc2
Copy link
Member

@philipc2 philipc2 commented May 2, 2024

Overview

  • Benchmarks the 480km and 120km MPAS ocean meshes that are used in the Unstructured Grid Visualization Cookbook, across multiple functionalities;
    • to_geodataframe() with and without antemeridian polygons
    • gradient()
    • integrate()

@philipc2 philipc2 self-assigned this May 2, 2024
@philipc2 philipc2 marked this pull request as ready for review May 3, 2024 15:17
@philipc2
Copy link
Member Author

philipc2 commented May 3, 2024

120km: (59,329 nodes, 87980 edges, 28571 faces)

480km: (3947 nodes, 5754 edges, 1791 faces)

About a 15x increase in the number of each elements going from 480km to 120km

@philipc2
Copy link
Member Author

philipc2 commented May 3, 2024

Results. The ~15x expect increase for linear scaling functions is present in most of these benchmarks.

Screenshot 2024-05-03 103856

@philipc2
Copy link
Member Author

philipc2 commented May 3, 2024

@anissa111

I've added you as a reviewer in case you were interested in taking a look, however don't feel obligated to actually give it a review!

@philipc2
Copy link
Member Author

philipc2 commented May 3, 2024

Pinging @kafitzgerald if you want to take a look too!

Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

@philipc2 philipc2 linked an issue May 8, 2024 that may be closed by this pull request
@philipc2 philipc2 merged commit 46c4260 into main May 8, 2024
14 checks passed
@philipc2 philipc2 mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark n_nodes_per_face construction
2 participants