Added basic kaldi-gstreamer-server support #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi astropika, This looks pretty good so far - I'm going to merge this when I have some time. Just as a heads up, we'll need to make the following changes afterward:
|
|
Is there any update on when this may get pulled in? |
|
An open PR for about 15 months now? So, it will not happen. |
|
Any news on this? Could it be rebased on the last version @astropika ? |
|
Hey, @Uberi @astropika any word on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic support for kaldi-gstreamer-server, using their HTTP API.
A complete implementation would use chunked transfers or websocket to be faster (speech starts processing before it's all been sent) and more usable (timeouts) but I didn't want to add any dependencies.