Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide_codimd.rst #468

Closed
wants to merge 1 commit into from
Closed

Update guide_codimd.rst #468

wants to merge 1 commit into from

Conversation

kimdiallo
Copy link
Contributor

without NODE_OPTIONS=--max_old_space_size=1024npm run build is killed by OOM

without `NODE_OPTIONS=--max_old_space_size=1024`npm run build is killed by OOM
@SalocinHB
Copy link
Member

Can't get this to build with the option either

[testnico@stardust codimd]$ NODE_OPTIONS=--max_old_space_size=1024 npm run build
npm WARN lifecycle The node binary used for scripts is /bin/node but npm is using /opt/nodejs8/bin/node itself. Use the `--scripts-prepend-node-path` option to i
nclude the path for the node binary npm was executed with.

> CodiMD@1.5.0 build /home/testnico/codimd
> webpack --config webpack.prod.js --progress --colors --bail

 96% [0] chunk asset optimization TerserPluginKilled
[testnico@stardust codimd]$

@nichtmax nichtmax self-assigned this Oct 7, 2019
@nichtmax
Copy link
Member

nichtmax commented Oct 7, 2019

Does not work

@nichtmax nichtmax closed this Oct 7, 2019
SalocinHB referenced this pull request Nov 7, 2019
`npm run build` bails, `NODE_OPTIONS=--max_old_space_size=1024` does not do it's job 😞
@makomi
Copy link
Contributor

makomi commented Nov 7, 2019

Did you try it a second time right after? See the note in line 203 stating "[...] If the compilation fails the first time due to RAM limitations, just start it again. It tends to work the second time."

For me, it always failed the first time and always worked the second time. Would this be acceptable for you?

Personally, I wouldn't invest time to fix this and keep the guide online, because it always works the second time and I am not familiar with the tech stack, i.e. I would likely have to spend a lot of time to fix it and not significantly improve the result. I acknowledge that it is a dirty solution - and yet - a reliably working solution.

If it no longer works by just running the build command a second time, it is likely that CodiMD's code changed and additional modifications have to be made, to make the guide work again. This would be the second reason I can think of for why it does not build for you. I would like to understand which of the two it is.

@luksal
Copy link

luksal commented Nov 13, 2019

Works for me with option NODE_OPTIONS=--max_old_space_size=1024 and CodiMD version 1.5.0

@nichtmax nichtmax deleted the codimd-patch-2 branch March 12, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants