Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Nextcloud update #86

Closed
wants to merge 1 commit into from
Closed

Small Nextcloud update #86

wants to merge 1 commit into from

Conversation

splitt3r
Copy link
Contributor

@splitt3r splitt3r commented Apr 20, 2018 •
edited

I updated the awesome tutorial by @spacecodeit so the logo fits in and there was one wrong Nextcloud wording left.

Before:

before

@splitt3r
Copy link
Contributor Author

splitt3r commented Apr 20, 2018 •
edited

I think it would also be a great addition to give a hint about 'htaccess.IgnoreFrontController' => false,. I think a lot of people change that setting. Or in general link to https://docs.nextcloud.com/server/13/admin_manual/configuration_server/config_sample_php_parameters.html at the end of the tutorial.

SalocinHB
SalocinHB requested changes Apr 20, 2018
View reviewed changes
source/guide_nextcloud.rst
@@ -9,7 +9,7 @@
Nextcloud
#########

Nextcloud_ is an open source cloud solution written in PHP and distributed unter the AGPLv3 licence.
Nextcloud_ is an open source cloud solution written in PHP and distributed unter the AGPLv3 licence. You can find further infromation on how to secure and optimise your setup at the offical `docs page <https://docs.nextcloud.com>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but the link should probably be at the end of the article

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will have a look at resizing the logo so this text can be moved to the end oft the tutorial.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logo overlapping the box below is a general problem, which shouldn't be solved on a per-guide basis, imho.

luto added a commit that referenced this pull request Apr 21, 2018
@luto
✏️ NextCloud => Nextcloud
d91d370 
lifted from #86, thanks @splitt3r!
@luto luto mentioned this pull request Apr 21, 2018
Closed
@luto
Copy link
Member

luto commented Apr 21, 2018

I included the NextCloud fix manually. Since the main purpose of the additional link seems to be to fix the logo, I'm closing this for now. See #89.

@luto luto closed this Apr 21, 2018
nichtmax pushed a commit that referenced this pull request Apr 23, 2018
@luto @nichtmax
✏️ NextCloud => Nextcloud
35d059c 
lifted from #86, thanks @splitt3r!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luto luto luto left review comments

@SalocinHB SalocinHB SalocinHB requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@splitt3r @luto @SalocinHB