Alternative RPC for fetching events #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muhammedea is attempting to deploy a commit to the Ubeswap Team on Vercel. A member of the Team first needs to authorize it. |
BriungRi
approved these changes
Jan 11, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BriungRi
reviewed
Jan 11, 2024
|
@BriungRi I tried to add a test for fetchEvents function but it seems that without mocking RPC's it is not that useful. For the pages like stake, farm ... there are no test currently and those pages doesn't work. So only testing strategy right now is just manual testing. Do you have something in your mind for testing? |
|
manual testing is fine. Just wanted to make sure that was the minimum we did |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Celo public RPCs has problem when fetching all events. So I have added an infura url as an alternative rpc url. But the old forno url will be used too in case of infura failure. Also web3.js codes on farm pages refactored to ethers.js too.
With this fix, loading problems on governance, farm, limit order and pool pages should be fixed.