-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature-nav parameter missmatch #77
Comments
I don't know to which branch this is related since some of these information does not seem to be relevant for the "master" (kinetic-devel) branch. Kinetic devel features branch is currently applying step by step features, documentation etc. We should either update the issue or create a new one related to master branch since others are project specific. |
I'm unclear on the parameter names and if they are missmatched in the |
robot_front_length, robot_width, robot_back_length are parameters for robot footprint. |
okay, why do we need |
i guess what im asking is is there a scenario where |
It's hard to tell from code for sure(I would say we are using in paragraphs mentioned method) whether we are using |
@JanezCim are we clear on that? |
It's gonna be so funny when Janez wakes up on Thursday with a hundred million email pings from all repos. |
@tp4348 If you understand all the params, both in move_basic.cpp and in collision_checker.cpp, then im fine, we can solve further issues with understanding these down the line |
Im writing this as a separate issue, because this is more clear that just adding comments to #76.
In feature-nav branch there are some paramter missmatches that i've noticed:
These are just the parameters that i've noticed now. I think what happened is that move_basic was heavily modified without thinking about how collision_checker will be effected and now we have a slight parameter mess. I think we also have to look at collision checker and clear this before we merge into master.
This new heavily modified move_basic works very nicely, but since so many user-exposed params have changed maybe we have to think about this becoming a new version of move_basic (eg. move_basic2)
The text was updated successfully, but these errors were encountered: