Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:💪 render mermaid in md #183 #187

Merged
merged 6 commits into from
Dec 29, 2023

Conversation

ren-yamanashi
Copy link
Contributor

@ren-yamanashi ren-yamanashi commented Dec 29, 2023

Changes

How to check operation

  1. Modify package.json
- "book:build": "vitepress build book/online-book --base /chibivue/"
+ "book:build": "vitepress build book/online-book"
  1. You can run the following command to check if it is rendering correctly.
# ~/chibivue
pnpm run book:build
pnpm run book:preview

This is a video of the actual build ⬇️

2023-12-30.0.14.09.mov

remarks

There is a library that uses commonJs as part of the dependencies (dayjs) of vitepress-plugin-mermaid

@Ubugeeei
Copy link
Owner

@ren-yamanashi
Awesome!!! Thank you!!

@Ubugeeei Ubugeeei marked this pull request as draft December 29, 2023 14:44
@Ubugeeei Ubugeeei self-requested a review December 29, 2023 14:44
@Ubugeeei Ubugeeei self-assigned this Dec 29, 2023
@Ubugeeei Ubugeeei added the bug label Dec 29, 2023
@ren-yamanashi
Copy link
Contributor Author

ren-yamanashi commented Dec 29, 2023

@Ubugeeei

If you update pnpm-lock.yaml, a conflict will occur...

Even if you install vitepress-plugin-mermaid after updating pnpm-lock.yaml in the main branch, a conflict will occur. 😢

Is there a good solution?

@Ubugeeei
Copy link
Owner

If you update pnpm-lock.yaml, a conflict will occur...
Even if you install vitepress-plugin-mermaid after updating pnpm-lock.yaml in the main branch, a conflict will occur. 😢
Is there a good solution?

Your fork's main branch has some diffs of chibivue/main.

So, it might be resolved by syncing your fork branch. 😄

スクリーンショット 2023-12-29 23 49 51

@Ubugeeei
Copy link
Owner

@ren-yamanashi
Can this PR be merged?
Do you have any other plans to do something?

@ren-yamanashi
Copy link
Contributor Author

@Ubugeeei

Can this PR be merged?
Do you have any other plans to do something?

Nothing else!
It took a while to record the video

Please leave a review 🙇

@ren-yamanashi ren-yamanashi changed the title [WIP] feat:💪 render mermaid in md #183 feat:💪 render mermaid in md #183 Dec 29, 2023
@Ubugeeei Ubugeeei marked this pull request as ready for review December 29, 2023 15:18
@Ubugeeei
Copy link
Owner

thanks, perfect

@Ubugeeei Ubugeeei merged commit abe055e into Ubugeeei:main Dec 29, 2023
@Ubugeeei Ubugeeei mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants