supplement(parser): reason for looping and searching for tags in the function isEnd is #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubugeeei
requested changes
Jan 7, 2024
Comment on lines
286
to
301
| ```typescript | ||
| function isEnd(context: ParserContext, ancestors: ElementNode[]): boolean { | ||
| const s = context.source; | ||
|
|
||
| // sが"</"で始まり、かつその後にancestorsのタグ名が続くことを判定し、閉じタグがあるか(parseChildrenが終了するべきか)を判定します。 | ||
| if (startsWith(s, "</")) { | ||
| for (let i = ancestors.length - 1; i >= 0; --i) { | ||
| if (startsWithEndTagOpen(s, ancestors[i].tag)) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return !s; | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Please remove semi-colons and double quotes.
There was a problem hiding this comment.
I'm not sure my change that removes semi-colons and double quotes is ok, but I removed them anyway.
There was a problem hiding this comment.
Yep! This is fine.
I made a comprehensive commit regarding this format issue yesterday, but it seems like it hasn't been reflected in your branch. (Please sync it.)
shoma-mano
changed the title
Ubugeeei
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #213
I couldn't find clear reason for loop, so this tip is just things ubugeeei said in discord mostly.