Support dynamic dropdown items #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starzu
reviewed
Aug 29, 2019
bootstrap4/.js/src/main/scala/io/udash/bootstrap/dropdown/UdashDropdown.scala
Outdated
Show resolved
Hide resolved
bootstrap4/.js/src/main/scala/io/udash/bootstrap/dropdown/UdashDropdown.scala
Outdated
Show resolved
Hide resolved
Starzu
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial idea behind 79783e2 was to avoid additional
<span>element polluting the DOM in the typical, non-dynamic case. My proposal for the middle-ground between the original version and the current one is to introduce limited support which would push the responsibility for creating a wrappingElementto the API user.Closes #379