Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final view removal #432

Merged
merged 8 commits into from
Oct 29, 2019
Merged

Final view removal #432

merged 8 commits into from
Oct 29, 2019

Conversation

ddworak
Copy link
Member

@ddworak ddworak commented Oct 18, 2019

I'll backport docs fix to 0.8.x once we agree on the content.

@ddworak ddworak requested a review from bgrochal October 18, 2019 14:04
@ddworak ddworak requested a review from bgrochal October 29, 2019 07:46
Copy link
Member

@bgrochal bgrochal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions left. Good job! 👌

@ddworak ddworak force-pushed the final-view-removal branch 2 times, most recently from 22d783f to 2c412ed Compare October 29, 2019 12:26
@ddworak ddworak merged commit 0e45814 into master Oct 29, 2019
@ddworak ddworak deleted the final-view-removal branch October 29, 2019 13:00
@ddworak ddworak added this to the 0.9.0 milestone Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants