Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PropertyCreators usage #464

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Improve PropertyCreators usage #464

merged 2 commits into from
Nov 25, 2019

Conversation

ddworak
Copy link
Member

@ddworak ddworak commented Nov 22, 2019

  • avoid redundant creators - they're only used for creating new direct properties
  • cache some creators

@ddworak ddworak added this to the 0.9.0 milestone Nov 22, 2019
bgrochal
bgrochal approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@bgrochal bgrochal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with few suggestions left - please resolve them and optimize imports across your changeset since there are many unused PropertyCreator and ClassTag imports left after your refactoring.

core/.js/src/main/scala/io/udash/Application.scala Show resolved Hide resolved
core/.js/src/main/scala/io/udash/bindings/inputs/Select.scala Show resolved Hide resolved
@ddworak ddworak merged commit f4c5269 into roSubSeq Nov 25, 2019
@ddworak ddworak deleted the api-cleanups branch November 25, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrochal bgrochal bgrochal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddworak @bgrochal