Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiddle #480

Merged
merged 3 commits into from
Dec 19, 2019
Merged

Fiddle #480

merged 3 commits into from
Dec 19, 2019

Conversation

ddworak
Copy link
Member

@ddworak ddworak commented Dec 12, 2019

No description provided.

@ddworak
Copy link
Member Author

ddworak commented Dec 12, 2019

Closes #396

Copy link
Member

@bgrochal bgrochal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are few comments to the scalafiddle templates:

  • a10A6UA/0 lines 32-34: one could use
bind(numbers.transform((n: Seq[Int]) => n.mkString(", ")))

instead of

span(s"${n.get}, ").render

(no trailing comma + works without explicit getter),

  • ButwLWQ/0 line 17: errors unused,
  • ButwLWQ/0 line 12: placeholder could be considered for consistency with other fiddles.

@ddworak
Copy link
Member Author

ddworak commented Dec 19, 2019

@bgrochal I see your point from a "production code" standpoint, but I'm not sure they'll make a homepage intro demo better.

  • a10A6UA - we could just bind, but then it doesn't only append DOM nodes for new numbers, it rerenders the whole line, which doesn't showcase the property mechanism well enough. You could argue to use repeatWithNested, but .getting here is actually optimal, as long as we are guaranteed to only have structure changes.

  • ButwLWQ - this input is pre-filled and the input doesn't require any additional confirmation (e.g. Enter press), so the placeholder is omitted to make the demo simpler. errors is just to inform the reader about the content here, there's no IntelliJ at hand on udash.io ;)

@ddworak ddworak merged commit dde1e21 into 0.8.x Dec 19, 2019
@ddworak ddworak deleted the fiddle branch December 19, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants