DocumentFragments should be rendered conditionally #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and `produceWithNested` versions; `showIfElse` reimplemented in terms of `produce`.
ddworak
requested changes
Feb 11, 2020
charts/.js/src/main/scala/io/udash/wrappers/highcharts/config/utils/VerticalAlign.scala
Outdated
Show resolved
Hide resolved
core/.js/src/main/scala/io/udash/bindings/modifiers/PropertyModifier.scala
Outdated
Show resolved
Hide resolved
core/.js/src/test/scala/io/udash/bindings/TagsBindingTest.scala
Outdated
Show resolved
Hide resolved
This reverts commit 8460d74.
- overloaded data-binding methods reimplemented with chaining, - `customElementReplace` renamed to `customElementsReplace` for consistency, - unit tests for respecting custom DOM Nodes replacement enabled for both `produce` and `produceWithNested`.
ddworak
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showIfandshowIfElsemethods as call-by-name parameters to assure consistency withproduceandrepeat, as well as to enable conditional rendering of mutable nodes (likeDocumentFragment)produceAPI unified (no backwards compatibility violation)