Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid linear list usages in routing #551

Merged
merged 12 commits into from
Mar 26, 2020
Merged

Avoid linear list usages in routing #551

merged 12 commits into from
Mar 26, 2020

Conversation

ddworak
Copy link
Member

@ddworak ddworak commented Mar 21, 2020

  • filtering utils appended to created lists
  • .last calls etc.
  • usage of iterators / indexes where possible

@ddworak ddworak added this to the 0.9.0 milestone Mar 21, 2020
@ddworak ddworak requested a review from mowczare March 21, 2020 13:08
mowczare
mowczare approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@mowczare mowczare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w. minor

core/.js/src/main/scala/io/udash/view/ViewRenderer.scala Outdated Show resolved Hide resolved
utils/src/main/scala/io/udash/utils/FilteringUtils.scala Show resolved Hide resolved
utils/src/main/scala/io/udash/utils/FilteringUtils.scala Show resolved Hide resolved
@ddworak ddworak merged commit 1eb23b1 into master Mar 26, 2020
@ddworak ddworak deleted the routing branch March 26, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowczare mowczare mowczare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddworak @mowczare